Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt: rename atomic_virial to atom_virial in the model output #3226

Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Feb 4, 2024

To be consistent with TF, as discussed in #3213 (comment). Old PT models are expected to be incompatible.

To be consistent with TF.

Signed-off-by: Jinzhe Zeng <[email protected]>
@github-actions github-actions bot added the Python label Feb 4, 2024
@njzjz
Copy link
Member Author

njzjz commented Feb 4, 2024

cc: @CaRoLZhangxy @iProzd

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7db1fde) 74.97% compared to head (baa281a) 74.97%.
Report is 1 commits behind head on devel.

Files Patch % Lines
deepmd/pt/infer/deep_eval.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3226   +/-   ##
=======================================
  Coverage   74.97%   74.97%           
=======================================
  Files         363      363           
  Lines       32551    32551           
  Branches     1608     1613    +5     
=======================================
  Hits        24405    24405           
  Misses       7273     7273           
  Partials      873      873           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit 17f2c35 into deepmodeling:devel Feb 5, 2024
46 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants